Add failure event if target namespace is missed during transfer task processing #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Apr 21, 2022
| task.TargetWorkflowID, | ||
| task.TargetRunID, | ||
| attributes.Control, | ||
| enumspb.SIGNAL_EXTERNAL_WORKFLOW_EXECUTION_FAILED_CAUSE_EXTERNAL_WORKFLOW_EXECUTION_NOT_FOUND, |
There was a problem hiding this comment.
It's rare but namespace not found is also possible here I think. And currently we can't tell from the error if it's workflow not found or namespace not found.
There was a problem hiding this comment.
This is actually true for all 3 cases. I plan to add specific error for "namespace is not found" case and I will handle it here properly. Added TODO for now.
alexshtin
force-pushed
the
fix/start-child-ns-validation
branch
from
5ce93c6
to
4b9f800
Compare
yycptt
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add failure event if target namespace is missed during transfer task processing.
Why?
If namespace is deleted there is a chance that namespace existed when command was proccessed but got deleted when corresponding transfer task was processed. To handle this, corresponding failed event is recorded in caller history.
How did you test it?
New unit tests.
Potential risks
No risks.
Is hotfix candidate?
No.