Remove namespace field from ScheduleActivityTaskCommandAttributes message #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
feature/remove-cross-ns-activity
branch
from
e41619d
to
3766979
Compare
yycptt
approved these changes
Apr 21, 2022
yycptt
reviewed
Apr 21, 2022
alexshtin
force-pushed
the
feature/remove-cross-ns-activity
branch
from
9e76cf4
to
da8a74d
Compare
alexshtin
force-pushed
the
feature/remove-cross-ns-activity
branch
from
c837627
to
37855be
Compare
Good point. Now it does! |
yycptt
approved these changes
Apr 23, 2022
|
Some more context for what we are trying to do here.
But no logic will use those three fields. And in 1.18 those write logic will also be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove
namespacefield fromScheduleActivityTaskCommandAttributesmessage.Why?
To remove ability of cross namespace activity calls.
See temporalio/api#174 for more details.
How did you test it?
Existing tests.
Potential risks
Low risk:
namespacefield is not exposed for the most SDKs but there might be some unofficial SDK which will loose ability to start activity in another namespace.Is hotfix candidate?