Don't fail ContinueAsNew command if parent namespace doesn't exist #2767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
reviewed
Apr 25, 2022
| if err != nil { | ||
| return err | ||
| if err == nil { | ||
| parentNamespace = parentNamespaceEntry.Name() |
There was a problem hiding this comment.
i believe you only need to pass in namespace ID, so conversion is not necessary?
There was a problem hiding this comment.
No :-(. Name is stored in event attributes.
wxing1292
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Don't fail
ContinueAsNewcommand if parent namespace doesn't exist.Why?
ContinueAsNewcan be called for the same namespace only, but internally mutable state supports different parent namespace. In case if this feature will ever be used, with this PR, subsequient calls toContinueAsNewwon't fail and won't store parent namespace name (only Id).How did you test it?
Existing tests.
Potential risks
No risks.
Is hotfix candidate?
No.