Limit number of delete workflow executions retries #2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Apr 26, 2022
| @@ -166,27 +168,27 @@ func deleteWorkflowExecutions(ctx workflow.Context, params ReclaimResourcesParam | |||
|
|
|||
| if isAdvancedVisibility { | |||
| ctx3 := workflow.WithActivityOptions(ctx, ensureNoExecutionsAdvVisibilityActivityOptions) | |||
There was a problem hiding this comment.
Any reason to have both client side retry and activity server side retry?
There was a problem hiding this comment.
I don't want to introduce one more child workflow here, it is already pretty complex. Aslo in this case there is no backoff and I wouldn't even call it "rerty". It is mostly "try to do it with 3 attempts".
yux0
approved these changes
Apr 28, 2022
alexshtin
force-pushed
the
feature/limit-reclaim-resources-retries
branch
from
5fccc42
to
dbc1c6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Limit number of delete workflow executions retries.
Why?
Infinity retries might generate too much load on the cluster.
How did you test it?
Run locally.
Potential risks
No risks.
Is hotfix candidate?
No.