Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit task processing time #2770

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Apr 26, 2022

What changed?

  • Limit task processing time to 3s
  • 500ms for getting workflow execution lock
  • For workflow reset task and standby history resend the timeout is 20s and 30s (default) respectively. The timeout for resend is controlled by a dynamicconfig.

Why?

  • Host level pool require the processing for each task to be fast

How did you test it?

  • Integration tests & canary

Potential risks

  • In terms of short context time + retry adding more load to downstream, this should not be a problem as the new retry policy is much less aggressive compared to the previous one. If worker pool sees timeout errors, the task will skip in-place retry and be send back to the rescheduler and the exponential backoff policy will kick in.

Is hotfix candidate?

  • No.

@yycptt yycptt changed the base branch from deprecate-task-processor to master April 27, 2022 18:01
@yycptt yycptt changed the base branch from master to deprecate-task-processor April 27, 2022 18:01
@yycptt yycptt force-pushed the limit-task-context-timeout branch from 98fe3d3 to 25d04dd Compare April 27, 2022 18:13
@yycptt yycptt changed the base branch from deprecate-task-processor to master April 27, 2022 18:21
@yycptt yycptt marked this pull request as ready for review April 27, 2022 18:21
@yycptt yycptt requested a review from a team as a code owner April 27, 2022 18:21
@yycptt yycptt requested review from yiminc and wxing1292 April 28, 2022 17:51
@yycptt yycptt merged commit fcf7d19 into temporalio:master Apr 28, 2022
@yycptt yycptt deleted the limit-task-context-timeout branch April 28, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants