Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not wake up workflow in retry backoff upon signal #2771

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Do not wake up workflow in retry backoff upon signal #2771

merged 2 commits into from
Apr 27, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Apr 26, 2022

What changed?

  • Do not wake up workflow in retry backoff upon signal

Why?

  • Existing check only handles cron workflow not workflow retry.

How did you test it?

  • Added unit test

Potential risks

Is hotfix candidate?

  • no

@yycptt yycptt requested a review from yiminc April 26, 2022 22:58
@yycptt yycptt requested a review from a team as a code owner April 26, 2022 22:58
@yycptt yycptt merged commit f7efbad into temporalio:master Apr 27, 2022
@yycptt yycptt deleted the signal-workflow-retry branch April 27, 2022 00:26
yycptt added a commit that referenced this pull request May 5, 2022
@yycptt
Do not wake up workflow in retry backoff upon signal (#2771)
705cbe9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yycptt @yiminc