Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move history API logic into its own package #2780

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

wxing1292
Copy link
Contributor

@wxing1292 wxing1292 commented Apr 28, 2022

What changed?

  • Move workflow update logic util into api package
  • Move API consistency checker intp api package
  • Simplify history engine impl

Why?
Follow up of #2778: Code simplification & restructure

How did you test it?
No logic change, only moving things around

Potential risks
N/A

Is hotfix candidate?
N/A

* Move workflow update logic util into api package
* Move API consistency checker intp api package
* Simplify history engine impl
@wxing1292 wxing1292 requested a review from a team as a code owner April 28, 2022 18:18
@dnr
Copy link
Member

dnr commented Apr 28, 2022

Please rename files to ..._util.go

@wxing1292 wxing1292 merged commit c302cb3 into temporalio:master Apr 28, 2022
@wxing1292 wxing1292 deleted the perf-signal-with-start-1 branch April 28, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants