Remove task version and visibility timestamp override #2789

yycptt · 2022-04-29T22:16:45Z

What changed?

Remove setTaskInfo which overrides task version and visibility timestamp for immediate tasks

Why?

All tasks, when created already specified the desired version and visibility timestamp, no need to override
The overriding version is always namespace current version which may not be the right version for the task. and may cause the task to be dropped.

How did you test it?

Potential risks

Is hotfix candidate?

Remove task version and visibility timestamp override

719abcf

yycptt requested review from yux0 and wxing1292 April 29, 2022 22:16

yycptt marked this pull request as ready for review April 29, 2022 22:33

yycptt requested a review from a team as a code owner April 29, 2022 22:33

yux0 approved these changes Apr 29, 2022

View reviewed changes

yycptt merged commit 723b7a5 into temporalio:master Apr 29, 2022

yycptt deleted the remove-setTaskInfo branch April 29, 2022 23:38

yycptt added a commit that referenced this pull request May 5, 2022

Remove task version and visibility timestamp override (#2789)

f62095d

Provide feedback