Remove obsolete nil CloseTime check #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove obsolete
nilCloseTimecheck.Why?
DeleteExecutionVisibilityTaskcan be created with emptyCloseTimeand it means that visibility records needs to be deleted for open workflow execution. It is valid case and it can happen in replication stack. Obsolete case with Cassandra TTL is not valid anymore because visibility tasks are short lived and TTL was removed few releases ago.How did you test it?
Current tests and integration tests in upcoming PR.
Potential risks
No risks.
Is hotfix candidate?
No.