Rename clockpb to clocksbp import alias #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
approved these changes
May 7, 2022
yiminc
reviewed
May 7, 2022
There was a problem hiding this comment.
@alexshtin did you do this manually? I would hope not. If this is done by some tool, can we enable this for everyone?
|
The tools is GoLand. I tried to share my settings through settings repository: https://github.com/temporalio/idea-settings but it seems that people don't like it. |
Not everyone uses GoLand :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Rename
clockpbtoclocksbpimport alias.Why?
For the sake of beauty and symmetry.
sin the import alias stays forserverand should be added everytime when server proto import is used.How did you test it?
N/A
Potential risks
No risks.
Is hotfix candidate?
No.