Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify child first workflow task scheduled #2822

Merged
merged 4 commits into from
May 10, 2022
Merged

Verify child first workflow task scheduled #2822

merged 4 commits into from
May 10, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented May 9, 2022

What changed?

  • Verify child first workflow task scheduled

Why?

  • If standby logic does not perform this verification, it's possible that after failover, child workflow only has started event but no first workflow task and its execution will be blocked.

How did you test it?

  • New unit test

Potential risks

Is hotfix candidate?

@yycptt yycptt requested review from yux0, wxing1292 and yiminc May 9, 2022 22:19
@yycptt yycptt requested a review from a team as a code owner May 9, 2022 22:19
@yycptt yycptt merged commit c118f6b into temporalio:master May 10, 2022
@yycptt yycptt deleted the verify-first-task-scheduled branch May 10, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yux0 yux0 yux0 approved these changes

@wxing1292 wxing1292 wxing1292 approved these changes

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yycptt @yux0 @wxing1292 @yiminc