Check workflow task after reapply events #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
approved these changes
May 12, 2022
yiminc
reviewed
May 12, 2022
|
|
||
| // After reapply event, checking if we should schedule a workflow task | ||
| // Do not create workflow task when the workflow is cron and the cron has not been started yet | ||
| if msBuilder.GetExecutionInfo().CronSchedule != "" && !msBuilder.HasProcessedOrPendingWorkflowTask() { |
There was a problem hiding this comment.
instead of checking for cronSchedule, you should check firstWorkflowTaskBackoff
There was a problem hiding this comment.
If cron has the first wf task, then we should continue schedule a task. Is this correct?
There was a problem hiding this comment.
We also need to take care of workflow retry backoff case I think.
yycptt
approved these changes
May 12, 2022
service/history/historyEngine.go
Outdated
Comment on lines
2848
to
2850
| // Do not create workflow task when the workflow has first workflow task backoff and execution is not started yet | ||
| workflowTaskBackoff := timestamp.TimeValue(executionInfo.GetExecutionTime()).After(timestamp.TimeValue(executionInfo.GetStartTime())) | ||
| if workflowTaskBackoff && !mutableState.HasProcessedOrPendingWorkflowTask() { |
There was a problem hiding this comment.
Shall we create a util function for this check?
There was a problem hiding this comment.
👍 this is also needed here
temporal/service/history/historyEngine.go
Line 1804 in 87c3beb
yiminc
approved these changes
May 12, 2022
meiliang86
pushed a commit
that referenced
this pull request
May 12, 2022
* Check workflow task after reapply events
meiliang86
pushed a commit
that referenced
this pull request
May 27, 2022
* Check workflow task after reapply events
meiliang86
pushed a commit
that referenced
this pull request
Jun 1, 2022
* Check workflow task after reapply events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Check workflow task after reapply events
Why?
When reapply event to current branch, we need to check if it should schedule a new workflow task
How did you test it?
Potential risks
Is hotfix candidate?