Fix docker template to handle SQLAuthPlugin config block #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock Signed-off-by: Alexander Mays <alex@eastside.io>
yiminc
approved these changes
May 14, 2022
gnz00
added a commit
to gnz00/temporal
that referenced
this pull request
Jul 9, 2022
…config block (temporalio#2844)" This reverts commit 5acbdd7.
yiminc
pushed a commit
that referenced
this pull request
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Mays alex@eastside.io
What changed?
During the review process on the PR to add the SQL Auth Plugin, a new configuration block was added however the docker template was not updated to reflect that.
Why?
How did you test it?
Potential risks
Is hotfix candidate?
No