Replicate workflow state #2852
Merged
Replicate workflow state #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
May 17, 2022
common/persistence/dataInterfaces.go
Outdated
Comment on lines
69
to
72
| CreateWorkflowModeUpdateCurrent | ||
| // CreateWorkflowModeZombie do not update current record since workflow is in zombie state | ||
| // applicable for CreateWorkflowExecution, UpdateWorkflowExecution | ||
| CreateWorkflowModeZombie | ||
| CreateWorkflowModeBypassCurrent |
| if workflowState == enumsspb.WORKFLOW_EXECUTION_STATE_CREATED || | ||
| workflowState == enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING || | ||
| workflowState == enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED { | ||
| workflowState == enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING { |
There was a problem hiding this comment.
I think WORKFLOW_EXECUTION_STATE_COMPLETED is still possible, isn't?
There was a problem hiding this comment.
If the current workflow vector clock is newer than the incoming closed workflow, then we can still create the closed workflow and not update the current record.
yiminc
approved these changes
May 18, 2022
Sushisource
pushed a commit
to Sushisource/temporal
that referenced
this pull request
Jun 7, 2022
* Replicate workflow state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Allow replicate workflow state.
Why?
Allow replicate workflow state for namespace migration optimization.
How did you test it?
TODO: unit tests
Potential risks
Is hotfix candidate?