Add sync workflow state task #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
May 21, 2022
| SyncShardStatusTaskAttributes sync_shard_status_task_attributes = 5; | ||
| SyncActivityTaskAttributes sync_activity_task_attributes = 6; | ||
| // TODO: deprecate once kafka deprecation is done. | ||
| HistoryMetadataTaskAttributes history_metadata_task_attributes = 7; | ||
| HistoryTaskV2Attributes history_task_v2_attributes = 8; |
There was a problem hiding this comment.
is it possible to rename this field?
There was a problem hiding this comment.
Yes. We can do it. I will do it in a separate PR.
proto/internal/temporal/server/api/replication/v1/message.proto
Outdated
Show resolved
Hide resolved
| workflowID := taskInfo.WorkflowID | ||
| runID := taskInfo.RunID | ||
| taskID := taskInfo.TaskID | ||
| return p.processReplication( |
There was a problem hiding this comment.
not relevant to this PR, but I think we also need to handle namespace not found error inside processReplication(). Probably also in replication executor on receiver end.
Sushisource
pushed a commit
to Sushisource/temporal
that referenced
this pull request
Jun 7, 2022
* Add sync workflow state task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add sync workflow state task
Why?
To replicate workflow state
How did you test it?
TODO: Integration test
Potential risks
Is hotfix candidate?