Delete global namespace #2867
Merged
Delete global namespace #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
May 20, 2022
| return e.namespaceEntry.ReplicationPolicy() == namespace.ReplicationPolicyMultiCluster | ||
| return e.namespaceEntry.ReplicationPolicy() == namespace.ReplicationPolicyMultiCluster && | ||
| // Don't replicate workflow executions in deleted namespace. | ||
| e.namespaceEntry.State() != enumspb.NAMESPACE_STATE_DELETED |
| } | ||
|
|
||
| if err != nil { | ||
| if _, isNotFound := err.(*serviceerror.NamespaceNotFound); isNotFound { |
There was a problem hiding this comment.
nit: can we define a util function for this check? maybe in the common package?
There was a problem hiding this comment.
no. I am against this. go codders should suffer from all go features!
alexshtin
force-pushed
the
feature/delete-global-namespace
branch
from
a4a3a8c
to
2bb0a49
Compare
Sushisource
pushed a commit
to Sushisource/temporal
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add support to delete global namespace.
Why?
Some checks needs to be added to support deletion of global namespace.
How did you test it?
Manually in local "global" cluster.
Potential risks
No risks.
Is hotfix candidate?
No.
Notes on delete global namespace
This will eventually go to the docs.
Namespace deletion is not automatically replicated. This works as extra safety net and global namespaces must be deleted manually in every cluster. Rename is not propagated either because it happens after changing of namespace state.
Namespace should be deleted in active cluster first. Otherwise deletion in stand by cluster might take longer because running workflows will be resurrected from active cluster.
See #2855 for more details on deletion of workflow execution.