Return error when cluster info is not found #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
May 19, 2022
Comment on lines
+511
to
+514
| adminClient, err := t.shard.GetRemoteAdminClient(t.clusterName) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Ideally we can create this admin client when initializing the standby executor (in the caller) instead of getting admin client on every call to fetchHistory func. But in #2864 I am changing the logic to something like this so that one standby executor can process all standby tasks, no matter what their active cluster is.
So I guess this comment is mainly for other reviewers.
Sushisource
pushed a commit
to Sushisource/temporal
that referenced
this pull request
Jun 7, 2022
* Return error when cluster info is not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Return error when cluster info is not found
Why?
The cluster info and namespace are both updated in frontend. There is a race conditional in history service, the namespace is updated earlier than the cluster info. This should recover after retries.
How did you test it?
Existing unit tests
Potential risks
Is hotfix candidate?