Add cluster ID to clock #2871
Merged
Add cluster ID to clock #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
commented
May 19, 2022
| @@ -59,6 +59,8 @@ type ( | |||
| IsGlobalNamespaceEnabled() bool | |||
| // IsMasterCluster whether current cluster is master cluster | |||
| IsMasterCluster() bool | |||
| // GetClusterID return the cluster ID, which is also the initial failover version | |||
| GetClusterID() int64 | |||
There was a problem hiding this comment.
I think UUID is overkill. Initial failover should be good.
yiminc
approved these changes
May 19, 2022
| @@ -59,6 +59,8 @@ type ( | |||
| IsGlobalNamespaceEnabled() bool | |||
| // IsMasterCluster whether current cluster is master cluster | |||
| IsMasterCluster() bool | |||
| // GetClusterID return the cluster ID, which is also the initial failover version | |||
| GetClusterID() int64 | |||
There was a problem hiding this comment.
I think UUID is overkill. Initial failover should be good.
yycptt
approved these changes
May 19, 2022
yycptt
reviewed
May 19, 2022
service/history/vclock/vclock.go
Outdated
| ) (int, error) { | ||
| if clock1.GetId() != clock2.GetId() { | ||
| if clock1.GetClusterId() != clock2.GetClusterId() || clock1.GetShardId() != clock2.GetShardId() { |
There was a problem hiding this comment.
We probably need to differentiate those two cases? ShardID not equal is unexpected, while clusterID not equal is expected in some cases (due to auto-forwarding).
There was a problem hiding this comment.
good point, actually even without the cluster ID, clocks generated by different cluster cannot be compared
Sushisource
pushed a commit
to Sushisource/temporal
that referenced
this pull request
Jun 7, 2022
* Add cluster ID to clock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Business logic can tell the difference (clock generated by cluster a vs cluster b)
How did you test it?
Existing tests
Potential risks
N/A
Is hotfix candidate?
N/A