Clean up dynamic configs #2877
Merged
Clean up dynamic configs #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreiding
reviewed
May 20, 2022
| system.advancedVisibilityWritingMode: | ||
| - value: "off" | ||
| constraints: {} | ||
| #frontend.enableClientVersionCheck: |
There was a problem hiding this comment.
This might be a good time to include some sort of link to docs as a comment?
Instead of a structure that might go stale?
But maybe just for docker-compose repo?
There was a problem hiding this comment.
This is for server developers only. They know where to look (code).
jbreiding
reviewed
May 20, 2022
config/development_active.yaml
Outdated
| @@ -117,5 +117,5 @@ publicClient: | |||
| hostPort: "localhost:7233" | |||
|
|
|||
| dynamicConfigClient: | |||
| filepath: "config/dynamicconfig/development_es.yaml" | |||
| filepath: "config/dynamicconfig/development_cass.yaml" | |||
| pollInterval: "10s" | |||
There was a problem hiding this comment.
this might be a good time to fix this by adding a newline
jbreiding
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Clean up dynamic configs.
Why?
Previous values were similar to defaults and there is no reason to set them explicitly in dynamic configs. Default values for advanced visibility are also auto configured based on static configs.
docker.yamlis an empty file for default docker configuration.Related PRs:
temporalio/docker-builds#50
temporalio/docker-compose#108
How did you test it?
Run different configurations locally. Build docker image locally and run it with
docker-compose.Potential risks
No risks. All configs in this repo are just for server developers.
Is hotfix candidate?
No.