Remove deprecated shard info ack level fields #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
May 21, 2022
common/log/tag/tags.go
Outdated
| return NewAnyTag("shard-timer-acks", shardTimerAcks) | ||
| // ShardQueueAcks returns tag for shard queue ack levels | ||
| func ShardQueueAcks(shardQueueAcks interface{}) ZapTag { | ||
| return NewAnyTag("shard-queue-acks", shardQueueAcks) |
There was a problem hiding this comment.
could you double check this could actually print the content of the map, not just the pointer to the map.
There was a problem hiding this comment.
Yes, I tried locally. It will print the actual content of shardInfo.QueueAckLevels.
But the one downside of the currently implementation is that the map key is the task category ID instead of the name.
I can change this function to take in category name as well and make it part of the tag key. Then each task category can have its own tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?