Per-service fx-ified OTEL tracing #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcshane
changed the title
alexshtin
approved these changes
Jun 6, 2022
jbreiding
reviewed
Jun 7, 2022
| versionHeadersInterceptor, | ||
| metrics.NewClientMetricsTrailerPropagatorInterceptor(logger), | ||
| errorInterceptor, | ||
| append( |
There was a problem hiding this comment.
Is the order important here?
If so we should probably leave a comment as such.
There was a problem hiding this comment.
There's sort of a bigger problem in that we have some interceptors that are hard-coded to exist and another set that comes from runtime parameters so if there was some sort of important ordering dependency then it would be difficult to resolve.
That said, in this case where I happen to know that the interceptor slice contains just the trace interceptor (or is empty) then the order isn't all that imporant.
dnr
reviewed
Jun 7, 2022
| @@ -28,3 +28,5 @@ | |||
| # Fossa | |||
| .fossa.yml | |||
|
|
|||
| # direnv | |||
| .envrc | |||
There was a problem hiding this comment.
just fyi, my strategy is to put an .envrc in the directory above this repo, so I can share it with the other temporal repos too
added 23 commits
June 21, 2022 13:11
Removes the serviceName parameter from the ServiceTrackingModule function (now just a var) as that piece of data can be read from the DI container as a dependency. Also inits the OTEL error logger to delegate to the server's Zap logger.
Host and process attributes can be auto-detected.
Do this so that we can make the ClientConn dialing lazy (i.e. occurs at when Start() is called on the exporter) because (a) that's preferrable anyway and (b) easier to unit test when construction and execution phases are separate.
Made valueOrDefault more general and renamed to coalesce
added 2 commits
June 21, 2022 13:11
Avoid possible confusion with temporal sdk
alexshtin
reviewed
Jun 22, 2022
added 2 commits
June 22, 2022 11:58
Avoids potential naming confusion with Temporal SDK related packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Configures OTEL tracing from configuration YAML and injects into the main 4 services (frontend, history, matching, worker)
Why?
Providing TracerProvider/Tracer instances to key types allows us to create and export spans, thereby improving runtime observability.
How did you test it?
Existing and new unit tests. If the fx changes are broken then the server will refuse to come up.
Also manual testing with a local otelcol
Potential risks
Low risk - If you don't have an
otelstanza in your config yaml to set up some exporters file then nothing is going to run.Is hotfix candidate?
No