Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly initialize task key fire time #2907

Merged
merged 4 commits into from
May 26, 2022
Merged

Properly initialize task key fire time #2907

merged 4 commits into from
May 26, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented May 26, 2022 •
edited

What changed?

  • New init function for creating task Key to ensure task key fire time has unix nano value > 0

Why?

How did you test it?

  • Existing tests.

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from wxing1292 May 26, 2022 19:40
@yycptt yycptt requested a review from a team as a code owner May 26, 2022 19:40
@yycptt yycptt merged commit 9bfadcd into temporalio:master May 26, 2022
@yycptt yycptt deleted the init-task-key branch May 26, 2022 21:51
@yycptt yycptt mentioned this pull request May 26, 2022
Merged
Sushisource pushed a commit to Sushisource/temporal that referenced this pull request Jun 7, 2022
@yycptt @Sushisource
Properly initialize task key fire time (temporalio#2907)
7666600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxing1292 wxing1292 wxing1292 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yycptt @wxing1292