Add close time in mutable state #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
May 31, 2022
| } else { | ||
| closeTime = completionEvent.GetEventTime() | ||
| } | ||
| closeTime = executionInfo.GetCloseTime() |
There was a problem hiding this comment.
I think we still need the fallback logic for at least one release?
There was a problem hiding this comment.
Shall we call mutableState.GetWorkflowCloseTime as well here? or we don't care about compatibility for admin commands?
There was a problem hiding this comment.
Cannot get the mutable state in admin service. I think I still need your get completion event here for compatibility.
yycptt
approved these changes
May 31, 2022
| } else { | ||
| closeTime = completionEvent.GetEventTime() | ||
| } | ||
| closeTime = executionInfo.GetCloseTime() |
There was a problem hiding this comment.
Shall we call mutableState.GetWorkflowCloseTime as well here? or we don't care about compatibility for admin commands?
Sushisource
pushed a commit
to Sushisource/temporal
that referenced
this pull request
Jun 7, 2022
* Add close time in mutable state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add close time in mutable state
Why?
In some code path, we don't need to fetch complete event to get the close time.
How did you test it?
Unit tests
Potential risks
Is hotfix candidate?