Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update replication processor/executor init logic #2926

Merged
merged 11 commits into from
Jun 3, 2022

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Jun 1, 2022

What changed?

  1. Remove replication processor factory implement queue interface.
  2. Use fx provider replication task executor provider function.

Why?
Extensibility for future use case.

How did you test it?
Local xdc test

Potential risks

Is hotfix candidate?

@yux0 yux0 requested review from yycptt and yiminc June 1, 2022 06:09
@yux0 yux0 requested a review from a team as a code owner June 1, 2022 06:09
common/resource/fx.go Outdated Show resolved Hide resolved
host/onebox.go Outdated Show resolved Hide resolved
@@ -25,6 +25,7 @@
package history

import (
"go.temporal.io/server/service/history/replication"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move to L31

service/history/replication/dlq_handler.go Show resolved Hide resolved
service/history/workflow/context.go Outdated Show resolved Hide resolved
@yux0 yux0 merged commit 4c11b96 into temporalio:master Jun 3, 2022
@yux0 yux0 deleted the refactor-replicaiton-executor branch June 3, 2022 05:46
Sushisource pushed a commit to Sushisource/temporal that referenced this pull request Jun 7, 2022
* Update replication processor/executor init logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants