Fill in fields in ListSchedulesResponse #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Jun 3, 2022
alexshtin
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Use search attributes to pass a subset of current schedule state through to visibility. This uses a proto message encoded as json in a keyword search attribute, which is the best option for now.
Add a length limit on the notes field, enforced at the frontend.
Why?
So that we can see some details when listing schedules, without doing n describe calls.
How did you test it?
tested manually for now, will be part of future integration tests
Potential risks
If the search attribute value is too large (determined by dynamic config, default 2048 bytes), the server unceremoniously kills the workflow. So we should try to keep it under that limit. We can do that by encoding it as a payload (which double-jsons the json string) and measuring that. If it's too big, we can drop some (or all) fields to attempt to stay under the limit.