Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix host level task scheduler start/stop #2948

Merged
merged 4 commits into from
Jun 4, 2022
Merged

Fix host level task scheduler start/stop #2948

merged 4 commits into from
Jun 4, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Jun 4, 2022

What changed?

  • Fix host level task scheduler start/stop

Why?

  • Currently task scheduler start/stop is always done on shard level, even when the scheduler is a host level scheduler.
  • When shard movement happens, the host level scheduler will also get stopped.

How did you test it?

  • Tested locally using canary with both host level pool enabled and disabled. Also randomly closing shards.

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from yiminc June 4, 2022 07:13
@yycptt yycptt requested a review from a team as a code owner June 4, 2022 07:13
@yycptt yycptt enabled auto-merge (squash) June 4, 2022 07:33
@yycptt yycptt merged commit 8444848 into temporalio:master Jun 4, 2022
Sushisource pushed a commit to Sushisource/temporal that referenced this pull request Jun 7, 2022
@yycptt @Sushisource
Fix host level task scheduler start/stop (temporalio#2948)
e78dc5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxing1292 wxing1292 wxing1292 approved these changes

@yiminc yiminc Awaiting requested review from yiminc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yycptt @wxing1292