Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for nil config and return noop #2979

Merged
merged 1 commit into from
Jun 9, 2022
Merged

check for nil config and return noop #2979

merged 1 commit into from
Jun 9, 2022

Conversation

jbreiding
Copy link
Contributor

What changed?
nil check and return noop

Why?
simplify init of metricHandler
this pattern is employed by consumers of this function.

How did you test it?
unit-tests

Potential risks
None

Is hotfix candidate?
No

@jbreiding jbreiding requested a review from a team as a code owner June 9, 2022 02:58
@jbreiding jbreiding merged commit 5135a68 into temporalio:master Jun 9, 2022
@jbreiding jbreiding deleted the simplify-nil-handling branch June 9, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbreiding @yiminc