Don't check delete workflow execution transfer task version #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
approved these changes
Jun 27, 2022
alexshtin
added a commit
that referenced
this pull request
Jul 8, 2022
yux0
added a commit
to yux0/temporal
that referenced
this pull request
Jul 27, 2022
…emporalio#3021)" This reverts commit 2d0071d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Don't check delete workflow execution transfer task version.
Why?
DeleteExecutionTasktransfer task is create when workflow is explicitly deleted withDeleteWorkflowExecutionAPI call.There is no need to check task version when processing this task because API request to delete executions is considered to be higher priority than other processes which might resurrect execution.
Also removed version from
DeleteExecutionVisibilityTaskbecause it is not used by processor.How did you test it?
Existing tests.
Potential risks
No risks.
Is hotfix candidate?
Yes, for end to end namespace migration tests.