Release shard lock earlier during delete workflow execution #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Jun 27, 2022
| @@ -1004,6 +1004,8 @@ func (s *ContextImpl) DeleteWorkflowExecution( | |||
| return err | |||
| } | |||
|
|
|||
| s.wUnlock() | |||
There was a problem hiding this comment.
Release when returning errors as well please.
yycptt
approved these changes
Jun 27, 2022
alexshtin
force-pushed
the
feature/move-lock-delete
branch
from
9ebe589
to
797d9a0
Compare
alexshtin
added a commit
that referenced
this pull request
Jul 8, 2022
alexshtin
added a commit
that referenced
this pull request
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Release shard lock earlier during delete workflow execution.
Why?
Delete workflow execution is 4 step process. Shard lock needs to be holded only during first 2 steps, not all 4.
How did you test it?
Exisitng tests.
Potential risks
No risks.
Is hotfix candidate?
No.