Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle workflow already completed when verifying first workflow task scheduled #3061

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Handle workflow already completed when verifying first workflow task scheduled #3061

merged 2 commits into from
Jul 5, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Jul 5, 2022 •
edited
Loading

What changed?

  • Handle workflow already completed error when verifying first workflow task scheduled

Why?

  • We should not retry verification when workflow is already completed.

How did you test it?

  • Unit test

Potential risks

Is hotfix candidate?

  • Yes

@yycptt yycptt requested review from alexshtin and yux0 July 5, 2022 23:26
@yycptt yycptt requested a review from a team as a code owner July 5, 2022 23:26
@yycptt
Copy link
Member Author

yycptt commented Jul 5, 2022

#3062

@yycptt yycptt merged commit d02851f into temporalio:master Jul 5, 2022
@yycptt yycptt deleted the fix-verify-first-wf-task branch July 5, 2022 23:55
alexshtin pushed a commit that referenced this pull request Jul 8, 2022
@yycptt @alexshtin
Handle workflow already completed when verifying first workflow task …
6737693 
…scheduled (#3061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin alexshtin approved these changes

@yux0 yux0 Awaiting requested review from yux0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yycptt @alexshtin