Fix queue rate limiting busy loop #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
reviewed
Jul 18, 2022
| @@ -414,12 +414,14 @@ func newQueueProcessorRateLimiter( | |||
| ) quotas.RateLimiter { | |||
| return quotas.NewMultiRateLimiter( | |||
| []quotas.RateLimiter{ | |||
| // consume from host rate limiter as it's usually the one throttles the traffic | |||
| // and avoid unnecessary consume and cancel on shard level rate limiter | |||
| hostRateLimiter, | |||
There was a problem hiding this comment.
will one rogue shard exhaust all host quota?
There was a problem hiding this comment.
My understanding is if later ratelimiter (the shard level one) can't pass, previous reservations will be cancelled.
https://github.com/temporalio/temporal/blob/master/common/quotas/multi_rate_limiter_impl.go#L106
There was a problem hiding this comment.
My local test shows it works fine. But theoretically one rogue shard can still affect others since other shard can try to get a host token before the rouge shard cancels it. So I reverted the change here to be safe.
The busy loop issue is still fixed.
yiminc
approved these changes
Jul 21, 2022
| @@ -414,12 +414,14 @@ func newQueueProcessorRateLimiter( | |||
| ) quotas.RateLimiter { | |||
| return quotas.NewMultiRateLimiter( | |||
| []quotas.RateLimiter{ | |||
| // consume from host rate limiter as it's usually the one throttles the traffic | |||
| // and avoid unnecessary consume and cancel on shard level rate limiter | |||
| hostRateLimiter, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
Potential risks
Is hotfix candidate?