Update shard replication timestamp with max generated task #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hehaifengcn
approved these changes
Jul 27, 2022
| } | ||
|
|
||
| func (p *ackMgrImpl) GetMaxTaskID() int64 { | ||
| func (p *ackMgrImpl) GetMaxTaskInfo() (int64, time.Time) { |
There was a problem hiding this comment.
nit: should we define a struct for return value?
There was a problem hiding this comment.
don't think it is necessary here.
| @@ -121,7 +121,7 @@ func (a *activities) checkReplicationOnce(ctx context.Context, waitRequest waitR | |||
| // Caught up to the last checked IDs, and within allowed lagging range | |||
| if clusterInfo.AckedTaskId >= waitRequest.WaitForTaskIds[shard.ShardId] && | |||
| (shard.MaxReplicationTaskId-clusterInfo.AckedTaskId <= waitRequest.AllowedLaggingTasks || | |||
| shard.ShardLocalTime.Sub(*clusterInfo.AckedTaskVisibilityTime) <= waitRequest.AllowedLagging) { | |||
| shard.MaxReplicationTaskVisibilityTime.Sub(*clusterInfo.AckedTaskVisibilityTime) <= waitRequest.AllowedLagging) { | |||
There was a problem hiding this comment.
do we have any integration tests which can validate the result here?
There was a problem hiding this comment.
Added a unit test in ack manager. The e2e is covered with int test.
yycptt
approved these changes
Jul 28, 2022
yux0
added a commit
that referenced
this pull request
Jul 29, 2022
* Update shard replication timestamp with max generated task
yux0
added a commit
to yux0/temporal
that referenced
this pull request
Aug 3, 2022
…o#3158) * Update shard replication timestamp with max generated task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Update shard replication timestamp with max generated task
Why?
The namespace migration workflow use the task timestamp to calculate replication lag. We should use the timestamp from replication stack instead of real timestamp.
How did you test it?
Potential risks
Is hotfix candidate?