Adds ability to specify sanitizeOptions for prometheus metrics #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underrun
reviewed
Aug 1, 2022
| func (s SanitizeRange) toTally() (tally.SanitizeRange, error) { | ||
| startRangeRunes := []rune(s.StartRange) | ||
| if len(startRangeRunes) != 1 { | ||
| return tally.SanitizeRange{}, fmt.Errorf("start range '%+v' must be a single rune", startRangeRunes) |
There was a problem hiding this comment.
does this give enough feedback for someone using something that looks like a single character but isn't ala https://en.wikipedia.org/wiki/Combining_character - maybe it does but just want to bring it up.
There was a problem hiding this comment.
i think the definition of a rune should make that clear as it maps to a Unicode Code Point
yiminc
reviewed
Aug 1, 2022
| return tally.SanitizeRange{}, fmt.Errorf("end range '%+v' must be a single rune", endRangeRunes) | ||
| } | ||
|
|
||
| return tally.SanitizeRange([2]rune{startRangeRunes[0], endRangeRunes[0]}), nil |
There was a problem hiding this comment.
yes, that is the tally-specific type. they take in an array of runes, not a slice
common/metrics/config.go
Outdated
Comment on lines
482
to
493
| return tally.SanitizeOptions{}, errors.New("invalid nameChars") | ||
| } | ||
|
|
||
| tallyKeyChars, err := s.KeyCharacters.toTally() | ||
| if err != nil { | ||
| return tally.SanitizeOptions{}, errors.New("invalid keyChars") | ||
| } | ||
|
|
||
| tallyValueChars, err := s.ValueCharacters.toTally() | ||
| if err != nil { | ||
| return tally.SanitizeOptions{}, errors.New("invalid valueChars") | ||
| } |
There was a problem hiding this comment.
the error should wrap the detailed error.
yiminc
approved these changes
Aug 1, 2022
mastermanu
added a commit
to mastermanu/temporal
that referenced
this pull request
Aug 2, 2022
…ralio#3170) This PR adds the ability to set specific tally.SanitizeOptions via temporal configuration. If the configuration is not set, we rely on the default that is defined in code. Otherwise, we will generate a tally.SanitizeOptions by parsing the configuration file and converting it to a tally.SanitizeOptions. Because configuration comes in via yaml, all relevant input fields are strings. The code converts the strings to runes and performs length check validations. Any invalid configuration will fail server startup.
mastermanu
added a commit
that referenced
this pull request
Aug 2, 2022
…etrics (#3170) (#3174) Adds ability to specify sanitizeOptions for prometheus metrics (#3170) This PR adds the ability to set specific tally.SanitizeOptions via temporal configuration. If the configuration is not set, we rely on the default that is defined in code. Otherwise, we will generate a tally.SanitizeOptions by parsing the configuration file and converting it to a tally.SanitizeOptions. Because configuration comes in via yaml, all relevant input fields are strings. The code converts the strings to runes and performs length check validations. Any invalid configuration will fail server startup.
alexshtin
pushed a commit
that referenced
this pull request
Aug 2, 2022
…etrics (#3170) (#3174) Adds ability to specify sanitizeOptions for prometheus metrics (#3170) This PR adds the ability to set specific tally.SanitizeOptions via temporal configuration. If the configuration is not set, we rely on the default that is defined in code. Otherwise, we will generate a tally.SanitizeOptions by parsing the configuration file and converting it to a tally.SanitizeOptions. Because configuration comes in via yaml, all relevant input fields are strings. The code converts the strings to runes and performs length check validations. Any invalid configuration will fail server startup.
yux0
pushed a commit
to yux0/temporal
that referenced
this pull request
Aug 3, 2022
…ralio#3170) This PR adds the ability to set specific tally.SanitizeOptions via temporal configuration. If the configuration is not set, we rely on the default that is defined in code. Otherwise, we will generate a tally.SanitizeOptions by parsing the configuration file and converting it to a tally.SanitizeOptions. Because configuration comes in via yaml, all relevant input fields are strings. The code converts the strings to runes and performs length check validations. Any invalid configuration will fail server startup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set specific tally.SanitizeOptions via temporal configuration. If the configuration is not set, we rely on the default that is defined in code. Otherwise, we will generate a tally.SanitizeOptions by parsing the configuration file and converting it to a tally.SanitizeOptions.
Because configuration comes in via yaml, all relevant input fields are strings. The code converts the strings to runes and performs length check validations. Any invalid configuration will fail server startup.