Use a prefix for scheduler workflow ids #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Prefix the workflow IDs of scheduler workflows with a constant string.
Why?
To avoid potential conflicts between user-chosen workflow IDs and schedule IDs, after we hide schedules from workflow visibility by default with "namespace divisions" in #3123.
How did you test it?
manual test
Potential risks
If anyone has schedules created before this, they won't be able to interact with them through the schedule api, they'll have to terminate the workflows with the workflow api and recreate them.
Is hotfix candidate?
maybe