Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline history archival #3216

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Aug 11, 2022

What changed?

  • The fix depends on Remove namespace max retention #3148
  • Do not call history client to delete workflow execution after inline archival is done
  • Get workflow close event (for getting close time) before attempting archival.

Why?

  • When deleting workflow execution, we already held the workflow lock. Calling history client delete workflow execution will try to lock the workflow again, which is guaranteed to fail.
  • Old versions (before the linked PR) of archival workflow will delete history after history archival is done. If workflow close event is read after sending archival request, the history may already gone and result in infinity task retry.

How did you test it?

  • Unit test.

Potential risks

Is hotfix candidate?

  • Yes.

@yycptt yycptt requested review from yux0 and yiminc August 11, 2022 22:57
@yycptt yycptt requested a review from a team as a code owner August 11, 2022 22:57
@yycptt yycptt merged commit 6fe8f3e into temporalio:master Aug 11, 2022
@yycptt yycptt deleted the fix-history-archival branch August 11, 2022 23:38
yycptt added a commit that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants