Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failover queue shutdown #3232

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Fix failover queue shutdown #3232

merged 3 commits into from
Aug 16, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Aug 16, 2022

What changed?

  • Fix failover queue shutdown

Why?

  • Failover queue shutdown doesn't follow the normal stop path. Instead stop is triggered from the ack manager. Currently this shutdown logic only shutdown the processor base, not the entire processor. This mean the failover queue worker pool is not stopped and lead to goroutine leak.

How did you test it?

  • Will do local test

Potential risks

Is hotfix candidate?

  • Yes.

@yycptt yycptt requested a review from yiminc August 16, 2022 02:01
@yycptt yycptt requested a review from a team as a code owner August 16, 2022 02:01
@yycptt yycptt enabled auto-merge (squash) August 16, 2022 05:49
@yycptt yycptt merged commit cd876ee into temporalio:master Aug 16, 2022
@yycptt yycptt deleted the fix-failover-queue-shutdown branch August 16, 2022 06:15
alexshtin pushed a commit that referenced this pull request Aug 16, 2022
@yycptt @alexshtin
Fix failover queue shutdown (#3232)
4426702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yycptt @yiminc