Remove frontend handler retries #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Aug 30, 2022
|
We decided not to do this. All commits should go on |
yiminc
requested changes
Aug 30, 2022
Comment on lines
+66
to
+69
| historyClientRetryMaxAttempts = 5 | ||
|
|
||
| matchingClientRetryInitialInterval = 1000 * time.Millisecond | ||
| matchingClientRetryMaxAttempts = 2 | ||
| matchingClientRetryMaxAttempts = 5 |
There was a problem hiding this comment.
Because we don't retry on handler level anymore, it makes sense to increase number of attempts from client themselves. 2 is too small for overall retry attempts.
yiminc
approved these changes
Aug 30, 2022
alexshtin
added a commit
that referenced
this pull request
Aug 30, 2022
alexshtin
added a commit
to alexshtin/temporal
that referenced
this pull request
Sep 7, 2022
alexshtin
added a commit
that referenced
this pull request
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove frontend handler retries.
Why?
Retries on frontend handler level may lead to unexpected
InvalidArgumenterrors. Closes #3282.How did you test it?
Existing tests.
Potential risks
No risks.
Is hotfix candidate?
Yes.