Fix merge map of payload #3412
Merged
Fix merge map of payload #3412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
reviewed
Sep 20, 2022
rodrigozhou
force-pushed
the
fix-merge-map-payload
branch
from
554f51b
to
23a41a1
Compare
alexshtin
reviewed
Sep 20, 2022
| if m1 == nil { | ||
| return maps.Clone(m2) | ||
| if m2 == nil { | ||
| return maps.Clone(m1) |
There was a problem hiding this comment.
Well, I think I could. But thought about what if it's changed outside after this function is called. It would change the map reference, and have unexpected side effects maybe. I don't know, just thought it would be safer like this.
alexshtin
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fixing the function to merge map of payload. Keys with nil value or empty slice value are removed.
Why?
A bug was leaving keys with nil or empty slice value in the merged map when the first map is nil.
How did you test it?
Added new unit tests to cover those cases.
Potential risks
No.
Is hotfix candidate?
Yes.