Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder grpc interceptors #3423

Merged
merged 7 commits into from
Sep 27, 2022
Merged

Reorder grpc interceptors #3423

merged 7 commits into from
Sep 27, 2022

Conversation

yux0
Copy link
Contributor

@yux0 yux0 commented Sep 23, 2022 •
edited
Loading

What changed?
Reorder interceptors

Why?

  1. Move interceptors that modify context between the retry interceptor and upstream.
  2. Move namespaceValidatorInterceptor before ratelimiterInterceptor as it should not take rate limit quota.

How did you test it?
local test

Potential risks

Is hotfix candidate?

@yux0 yux0 requested review from yycptt and yiminc September 23, 2022 04:14
@yux0 yux0 requested a review from a team as a code owner September 23, 2022 04:14
@yux0 yux0 changed the title Reorder grpc interceptor order Reorder grpc interceptors Sep 23, 2022
yiminc
yiminc reviewed Sep 23, 2022
View reviewed changes
common/rpc/interceptor/namespace_validator.go Outdated Show resolved Hide resolved
service/frontend/fx.go Show resolved Hide resolved
yiminc
yiminc approved these changes Sep 23, 2022
View reviewed changes
common/rpc/interceptor/namespace_validator.go Outdated
// 3. Namespace exists.
// 4. Namespace from request match namespace from task token, if check is enabled with dynamic config.
// 5. Namespace is in correct state.
// NamespaceValidatorInterceptor contains SizeValidationIntercept and StateValidationIntercept
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:/Size/Length/g

@yux0 yux0 merged commit b4b61ff into temporalio:master Sep 27, 2022
@yux0 yux0 deleted the retry-interceptor branch September 27, 2022 18:03
dnr pushed a commit that referenced this pull request Sep 29, 2022
@yux0 @dnr
Reorder grpc interceptors (#3423)
ca5d0fd 
* Reorder server interceptor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiminc yiminc yiminc approved these changes

@yycptt yycptt Awaiting requested review from yycptt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yux0 @yiminc