Per-namespace workers should only run on active cluster #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Sep 23, 2022
|
Do you know if the ns callback will be trigger in failover? If no, how can the passive start the per ns workflow after failover? |
It's a different ns callback.. I added another one that fires on state changes and ignores versions, for this purpose. I tested locally with two clusters and saw the worker get stopped and started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Check whether a namespace is active on this cluster before starting per-namespace worker.
Why?
No need to run workers for passive namespaces, save resources.
How did you test it?
unit test and manual test
Potential risks
Is hotfix candidate?
yes