Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log warning only when there is an error in SA size validation #3443

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Log warning only when there is an error in SA size validation #3443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 11 additions & 4 deletions service/history/commandChecker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,18 @@ func (c *workflowSizeChecker) checkIfSearchAttributesSizeExceedsLimit(
namespace namespace.Name,
commandTypeTag metrics.Tag,
) error {
c.metricsScope.Tagged(commandTypeTag).RecordDistribution(metrics.SearchAttributesSize, searchAttributes.Size())

c.metricsScope.Tagged(commandTypeTag).RecordDistribution(
metrics.SearchAttributesSize,
searchAttributes.Size(),
)
err := c.searchAttributesValidator.ValidateSize(searchAttributes, namespace.String())
c.logger.Warn("Search attributes size exceeds limits. Fail workflow.", tag.Error(err), tag.WorkflowNamespace(namespace.String()))

if err != nil {
c.logger.Warn(
"Search attributes size exceeds limits. Fail workflow.",
tag.Error(err),
tag.WorkflowNamespace(namespace.String()),
)
}
return err
}

Expand Down