Add execution scavenger for retention #3457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Oct 11, 2022
| ) | ||
|
|
||
| type ( | ||
| // mutableStateIDValidator is a validator that does shallow checks that | ||
| // * ID >= common.FirstEventID | ||
| // * ID <= last event ID | ||
| mutableStateIDValidator struct{} | ||
| mutableStateIDValidator struct { |
There was a problem hiding this comment.
Remove all ID in the names.
| return nil, err | ||
| } | ||
| retention := ns.Retention() | ||
| if ttl > 0 && ttl > retention { |
There was a problem hiding this comment.
Do we want to add some buffer here in case deletion time is not created/executed due to some other tasks pending (like archival task)?
There was a problem hiding this comment.
Yes. Add a buffer config
yycptt
approved these changes
Oct 13, 2022
dnr
pushed a commit
that referenced
this pull request
Oct 17, 2022
* Add execution scavenger for retention
dnr
pushed a commit
that referenced
this pull request
Oct 18, 2022
* Add execution scavenger for retention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add execution scavenger for retention
Why?
Scan execution table to find workflow data that pass the TTL.
How did you test it?
Local test
Potential risks
Is hotfix candidate?