Properly handle min task ID > max task ID case when shard is re-balancing #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
approved these changes
Oct 11, 2022
dnr
pushed a commit
that referenced
this pull request
Oct 17, 2022
…ing (#3470) * Properly handle min task ID > max task ID case by return unavailable error during shard re-balancing
dnr
pushed a commit
that referenced
this pull request
Oct 18, 2022
…ing (#3470) * Properly handle min task ID > max task ID case by return unavailable error during shard re-balancing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
During shard rebalancing, it is possible that a replication task poller contact new shard owner, then old shard owner: min task ID > max task ID; old shard owner should return unavailable error -> caller retry.
How did you test it?
N/A
Potential risks
N/A
Is hotfix candidate?
N/A