Fix scanner start dep #3513
Merged
Fix scanner start dep #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
approved these changes
Oct 19, 2022
alexshtin
approved these changes
Oct 19, 2022
| @@ -109,7 +109,7 @@ type ( | |||
| func New( | |||
| logger log.Logger, | |||
| cfg *Config, | |||
| sdkSystemClient sdkclient.Client, | |||
| sdkClientFactory sdk.ClientFactory, | |||
There was a problem hiding this comment.
Probably worth to add comment why client itself can't be injected here.
wxing1292
pushed a commit
that referenced
this pull request
Oct 19, 2022
norberthu
pushed a commit
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix scanner start dep
Why?
It should get system client in start()
How did you test it?
I tested with local start but it would be good to have functional test for the whole cluster.
Potential risks
Is hotfix candidate?