Wrap gocql.Iter with custom wrapper #3577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxing1292
approved these changes
Nov 10, 2022
alexshtin
force-pushed
the
fix/iter-wrapper
branch
from
64536e8
to
a9ba971
Compare
yiminc
approved these changes
Nov 11, 2022
|
Can we add a test for this? |
alexshtin
force-pushed
the
fix/iter-wrapper
branch
from
a9ba971
to
aad809c
Compare
|
@samarabbas, unfortunately, I can't reproduce the original error described in gocql/gocql#915. Methods, described there, don't work anymore. Apparently those bugs were fixed and we are hitting something else. Unit test also doesn't make much sense here, as it can only assert on return type which is obvious from the code. Also these wrappers are used for every Cassandra operation, so they are well covered with existing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Wrap
gocql.Iterwith custom wrapper.Why?
To use custom
handelErrorfunction to handleErrNoConnectionserror and recreate session.To temporally mitigate the error form gocql/gocql#915.
How did you test it?
Existing tests.
Potential risks
No risks.
Is hotfix candidate?
Yes.