Fix resilient shard #3584
Merged
Fix resilient shard #3584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Nov 14, 2022
| @@ -1933,7 +1933,18 @@ func (s *ContextImpl) acquireShard() { | |||
| return nil | |||
| } | |||
|
|
|||
| err := backoff.ThrottleRetry(op, policy, common.IsPersistenceTransientError) | |||
| // keep retrying except ShardOwnershipLostError or lifecycle context ended | |||
There was a problem hiding this comment.
Should we update common.IsPersistenceTransientError to exclude shard ownership lost error?
There was a problem hiding this comment.
IsPersistenceTransientError only return true for Unavailable and ResourceExhausted. ShardOwnershipLostError is already excluded there.
yiminc
force-pushed
the
fix_resilient_shard
branch
from
06d92a5
to
fdef158
Compare
yux0
approved these changes
Nov 14, 2022
|
This retry policy only apply to acquireShard, and initial backoff is 1s. |
dnr
reviewed
Nov 24, 2022
| err := backoff.ThrottleRetry(op, policy, common.IsPersistenceTransientError) | ||
| // keep retrying except ShardOwnershipLostError or lifecycle context ended | ||
| acquireShardRetryable := func(err error) bool { | ||
| if s.lifecycleCtx.Err() != nil { |
There was a problem hiding this comment.
you don't really have to check lifecycleCtx here: the first thing op does is check isValid, which checks if state >= stopping, and if so returns a shardownershiplost error. state >= stopping iff lifecycleCtx is cancelled.
I'd prefer not doing this additional check since it makes the code more confusing (to me). but it doesn't hurt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Keep acquireShard retrying except ShardOwnershipLostError or lifecycleCtx ended.
Why?
Resilient shard should not give up on other any other errors except ShardOwnershipLost error, for example should keep retry on timeout errors.
How did you test it?
Manual test locally with fault injection enabled (slightly modification so it does not return shard ownership error).
Potential risks
No.
Is hotfix candidate?
Yes.