Fix history scavenger bug on delete mutable state #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Nov 14, 2022
| @@ -339,6 +340,11 @@ func (s *Scavenger) cleanUpWorkflowPastRetention( | |||
| ctx context.Context, | |||
| mutableState *persistencepb.WorkflowMutableState, | |||
| ) error { | |||
| if mutableState.GetExecutionState().GetState() != enums.WORKFLOW_EXECUTION_STATE_COMPLETED { | |||
There was a problem hiding this comment.
Do we need to account for WORKFLOW_EXECUTION_STATE_VOID and WORKFLOW_EXECUTION_STATE_CORRUPTED here?
There was a problem hiding this comment.
This is only to clean up past retention data. Currently no plan to clean up corrupted data or in void state.
alexshtin
pushed a commit
that referenced
this pull request
Nov 15, 2022
* Check workflow state in scavenger * Log deleted workflow as record
alexshtin
pushed a commit
that referenced
this pull request
Nov 15, 2022
* Check workflow state in scavenger * Log deleted workflow as record
alexshtin
pushed a commit
that referenced
this pull request
Nov 15, 2022
* Check workflow state in scavenger * Log deleted workflow as record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix history scavenger bug on delete mutable state
Why?
How did you test it?
Add new unit tests.
Potential risks
No
Is hotfix candidate?
Yes