Add limits on other workflow fields #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
force-pushed
the
ms-limits/all-limits
branch
from
b06b380
to
2ffb372
Compare
MichaelSnowden
changed the base branch from
ms-limits/all-limits-base
to
ms-limits/remove-warning
MichaelSnowden
force-pushed
the
ms-limits/remove-warning
branch
from
3e1e95a
to
fe0f70a
Compare
MichaelSnowden
force-pushed
the
ms-limits/all-limits
branch
2 times, most recently
from
d3adf20
to
4e47e2b
Compare
yux0
approved these changes
Nov 18, 2022
service/history/configs/config.go
Outdated
Comment on lines
437
to
440
| NumPendingChildExecutionsLimit: dc.GetIntPropertyFilteredByNamespace(dynamicconfig.NumPendingChildExecutionsLimitError, 1000), | ||
| NumPendingActivitiesLimit: dc.GetIntPropertyFilteredByNamespace(dynamicconfig.NumPendingActivitiesLimitError, 1000), | ||
| NumPendingSignalsLimit: dc.GetIntPropertyFilteredByNamespace(dynamicconfig.NumPendingSignalsLimitError, 1000), | ||
| NumPendingCancelsRequestLimit: dc.GetIntPropertyFilteredByNamespace(dynamicconfig.NumPendingCancelRequestsLimitError, 1000), |
There was a problem hiding this comment.
have we reviewed this default numbers?
There was a problem hiding this comment.
Looks like we want to set these to 50K for now to not break anything
MichaelSnowden
force-pushed
the
ms-limits/all-limits
branch
from
4e47e2b
to
c5b27d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I added item count limits on three other fields in our mutable state (pending activities, pending cancel requests, pending signals).
Why?
I made this change to ensure that our workflows don't become too large.
How did you test it?
I just added the limits to our dynamic config, but they aren't enforced yet.
Potential risks
None.
Is hotfix candidate?
No.