Add an integration test for durable archival #3732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Dec 20, 2022
MichaelSnowden
force-pushed
the
durable-archival/integration-test-base
branch
from
3de6151
to
d875fee
Compare
MichaelSnowden
changed the base branch from
durable-archival/integration-test-base
to
master
MichaelSnowden
force-pushed
the
durable-archival/integration-test
branch
from
629002f
to
d8c10e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the merge base of this PR is a branch that contains commits from several of my other archival PRs. I will change the merge base to master and rerun the CI before landing this. I did this to unblock review of this PR
What changed?
I added an integration test that runs the archival suite with durable archival on and off.
Why?
I made these changes to enable us to add the archival queue with more confidence that it works.
How did you test it?
There were only a few code changes, and all of them are covered by the integration test.
Potential risks
An OSS user may now turn on durable archival if they see this flag, and we haven't QA'd this within our own test clusters yet.
Is hotfix candidate?
No. We should only send the notification when it's enabled by default.