Fix errcheck in ./common/persistence/ #3743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Dec 21, 2022
| @@ -1044,6 +1044,7 @@ type ( | |||
| } | |||
|
|
|||
| // Closeable is an interface for any entity that supports a close operation to release resources | |||
| // TODO: allow this method to return errors | |||
There was a problem hiding this comment.
Nothing worth having comes easy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
^
Why?
This will surface errors if we fail to close SQL databases in prod and in tests
How did you test it?
Reran errcheck
Potential risks
None because this just logs the close error instead of failing
Is hotfix candidate?
No